Skip to content

Fix overflow for build targets with 32-bit pointers #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix overflow for build targets with 32-bit pointers #13

wants to merge 3 commits into from

Conversation

Rizziepit
Copy link

Using usize for dataset size and derived values causes an overflow error for 32-bit build targets, e.g. WASM.

As an aside, #10 would have made this bug trivial to discover and solve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rizziepit @vgeddes